Add config option to conditionally enable RocksDB backend #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A TOML config section is added with a single key/value to enable RocksDB. The CMake variable
-DNANO_ROCKSDB=ONis required when building the node if wanting to use it though so that it has the required dependencies.There needed to be a way to conditionally use either LMDB/RocksDB when running our tests using the same build. This is done with a new environment variable
TEST_USE_ROCKSDB, not done in this task but travis will be modified to run tests with both backends.Also outputting what backend is used when the node is launched.
(Unrelated) Setting up the logging object in
core_testso that boost logging isn't output to standard out before a test has called it.