Replace account_info::rep_block with representative account #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
documentation
guilhermelawless
approved these changes
Sep 4, 2019
cryptocode
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently to find the representative from the
account_infoan extra read is needed to be done to get the rep block contents and get the representative from that. This causes slow-downs in the initial rep caching and delegator RPCs (so should fix #1517). Therep_blockhas now been replaced with the representative account itself.To prevent breaking existing service implementations,
rep_blockwill be determined on demand for RPCs which currently add to the responses (@guilhermelawless's recommendation), but will be marked as deprecated. In the new RPC 2.0 itrepresentativeshould be returned by default rather than require the flag"representative":"true"Note: Any ledgers used since #2174 will not be valid as this requires a database upgrade and those ledgers will already be on the same version!