This converts the socket IO timer to a timer started/stopped with raii. #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each socket has a deadline_next value that specifies when the next i/o deadline is to occur. Deadlines are either: a timeout for an I/O operation or, a timeout for inactivity. When an I/O operation completes, a deadline for inactivity is started. Each creation of a timer stores a timestamp and sets the deadline in the socket to be the same value. Upon timer destruction, iff the socket value equals the deadline timer, we'll set a new timeout deadline, otherwise we have overlapping I/O operations and another timer will do the deadline setting.
clemahieu
force-pushed
the
raii_timer
branch
from
99a77b5 to
0edb69a
Compare
SergiySW
previously approved these changes
Oct 9, 2020
thsfs
requested review from
dsiganos and
theohax
and removed request for
wezrule
Merged
|
This change brings code complexity and it is not clear that it gives us much in return. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each socket has a deadline_next value that specifies when the next i/o deadline is to occur.
Deadlines are either: a timeout for an I/O operation or, a timeout for inactivity. When an I/O operation completes, a deadline for inactivity is started.
Each creation of a timer stores a timestamp and sets the deadline in the socket to be the same value. Upon timer destruction, iff the socket value equals the deadline timer, we'll set a new timeout deadline, otherwise we have overlapping I/O operations and another timer will do the deadline setting.