Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Websocket Payment Tracking #3023

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

cryptocode
Copy link
Contributor

@cryptocode cryptocode commented Oct 26, 2020

This PR attempts to provide an easy and reliable way to get payment notifications, through a Websocket subscription. It's an alternative to block confirmation/pending/balance checks, and supports single-use accounts and block hand-off.

Preliminary documentation: https://github.com/cryptocode/notes/wiki/Websocket-Payment-Tracking

@cryptocode cryptocode added documentation This item indicates the need for or supplies updated or expanded documentation websockets labels Oct 26, 2020
@cryptocode cryptocode self-assigned this Oct 26, 2020
@zhyatt zhyatt requested review from wezrule and SergiySW October 27, 2020 16:10
@zhyatt zhyatt added this to the V22.0 milestone Oct 27, 2020
Copy link
Contributor

@wezrule wezrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice!! Having recently had the headache of doing something similar recently I can definitely see the usefulness.

@wezrule
Copy link
Contributor

wezrule commented Oct 28, 2020

I also agree it would be nice if wallets supported the "blob" qr code for sending from an account, for instance if the customer needs a refund can get it from the account (assuming the funds are pocketed first), and also for payouts from things like arcade machine.

wezrule
wezrule previously approved these changes Nov 2, 2020
@cryptocode cryptocode force-pushed the payment-notification branch 4 times, most recently from 382084f to 3882286 Compare November 23, 2020 22:40
@zhyatt zhyatt requested a review from wezrule January 26, 2021 14:55
@zhyatt zhyatt mentioned this pull request Feb 9, 2021
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This item indicates the need for or supplies updated or expanded documentation websockets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants