Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This disallows passing in a nullptr socket in to bootstrap_server. #3351

Merged
merged 1 commit into from
Jun 22, 2021
Merged

This disallows passing in a nullptr socket in to bootstrap_server. #3351

merged 1 commit into from
Jun 22, 2021

Conversation

clemahieu
Copy link
Contributor

This was only done in tests so it didn't reflect actual usage.

@clemahieu
This disallows passing in a nullptr socket in to bootstrap_server. Th…
adecb05 
…is was only done in tests so it didn't reflect actual usage.
@clemahieu clemahieu requested a review from thsfs June 21, 2021 17:17
@clemahieu clemahieu merged commit 3fefa73 into develop Jun 22, 2021
@zhyatt zhyatt added this to the V23.0 milestone Jun 22, 2021
@zhyatt zhyatt added the unit test Related to a new, changed or fixed unit test label Jul 16, 2021
@clemahieu clemahieu deleted the bootstrap_socket_nullptr branch July 20, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thsfs thsfs thsfs approved these changes

Assignees
No one assigned
Labels
unit test Related to a new, changed or fixed unit test
Projects
None yet
Milestone
V23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clemahieu @thsfs @zhyatt