Adds an Unchecked Map - wrapper for the unchecked table outside the store class #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsfs
force-pushed
the
unchecked_map
branch
3 times, most recently
from
0221ec3 to
e8a5292
Compare
thsfs
force-pushed
the
unchecked_map
branch
3 times, most recently
from
ad524a8 to
442acfa
Compare
clemahieu
force-pushed
the
unchecked_map
branch
from
43dab8b to
361d537
Compare
This comment has been minimized.
This comment has been minimized.
…d table. Rather than directly making modifications to the unchecked table, this ADT abstracts away the details of where this information is stored. nano::unchecked_map will queue write/trigger operations for processing in a background thread. This means nano::unchecked_map::put no longer requires a database transaction to call. This also changes the semantics of the unchecked put operations as they're no longer blocking, fix up many tests that made this assumption.
clemahieu
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a wrapper for the unchecked table, so it starts getting decoupled from the store logic, since this table is not part of the ledger. This will facilitate further refactoring like supporting more than type of DB instantiated.
It also simplifies the LMDB and RocksDB related implementation by removing source code from our side.