Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display node startup time for easy access to up time without RPC access #3601

Merged
merged 4 commits into from
Jan 2, 2022
Merged

Display node startup time for easy access to up time without RPC access #3601

merged 4 commits into from
Jan 2, 2022

Conversation

RickiNano
Copy link
Contributor

No description provided.

@clemahieu clemahieu added this to the V24.0 milestone Dec 13, 2021
@dsiganos
Copy link
Contributor

Personally, I think it should be the responsibility of the layer that starts nano_node (e.g. systemd) to record the start time and not nano_node itself but since it is just a single line, I have no objection to adding this.

However, printing localtime without printing timezone info would create as many problems as it solves.
Servers are typically running in different timezones from the operator and often are not setup properly for timezone and printing localtime usually creates too many problems. For this reason, usually timestamps are printed in UTC.

If we are going to print this, I think we should print in UTC and make it obvious in the output that it is UTC.

@RickiNano
Copy link
Contributor Author

That's a fair point. I have updated the PR to use UTC time

dsiganos
dsiganos previously approved these changes Dec 28, 2021
@dsiganos
Copy link
Contributor

Hi Ricki, please run the script ci/clang-format-do.sh to format the code, to commit code into the project, it must be formatted according to the rules of that script. The problem in your case is some extra spaces or tables at the end of one line. Other than that, your commit looks fine.

@dsiganos dsiganos self-requested a review December 28, 2021 10:48
@RickiNano
Copy link
Contributor Author

I was unable to run the clang-format-do.sh script. It's probably because I'm using windows. I downloaded the clang format plugin for Visual Studio and ran it. Hope it passes the test now

@dsiganos
Copy link
Contributor

Yes, it looks good now, thank you for doing the boring bits and pushing it all the way.

@clemahieu clemahieu merged commit 83d387f into nanocurrency:develop Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants