Backlog population is done by a linear scan separated by a 5 minute w… #3648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ait period. In this wait period and even while still scanning it's possible for the election scheduler to empty due to everything being confirmed faster than the scan can operate. This should be rewritten to not scan at all and instead, a new database table can store the bucket/time as a key and when buckets are emptyied, it can be refilled directly from disk without scanning.
jamescoxon
suggested changes
Jan 6, 2022
| { | ||
| std::cerr << "<---------------Populating...\n"; |
There was a problem hiding this comment.
Is a direct print to console needed here?
There was a problem hiding this comment.
I've done some testing on this PR and it looks really good
This is the baseline test (v23 RC3 branch)
Cycling is obvious
This V23 RC3 bu with included cherry pick of this PR:
No cycling and average CPS is approx three times higher
|
Duplicate of #3999 |
|
This just does the continuous backlog propagation in a a tight loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ait period. In this wait period and even while still scanning it's possible for the election scheduler to empty due to everything being confirmed faster than the scan can operate.
This should be rewritten to not scan at all and instead, a new database table can store the bucket/time as a key and when buckets are emptyied, it can be refilled directly from disk without scanning.