Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test confirmation_height.election_winner_details_clearing #3688

Closed
wants to merge 2 commits into from
Closed

Fix unit test confirmation_height.election_winner_details_clearing #3688

wants to merge 2 commits into from

Conversation

theohax
Copy link
Contributor

@theohax theohax commented Jan 24, 2022

One more unit test fix. Updating the linked #3608 issue as well.

@theohax theohax added bug unit test Related to a new, changed or fixed unit test labels Jan 24, 2022
@theohax theohax linked an issue Jan 24, 2022 that may be closed by this pull request
Unit test confirmation_height.election_winner_details_clearing intermittently failing #3608
Closed
@theohax
Copy link
Contributor Author

theohax commented Jan 24, 2022

node.vote_republish failed in the CI, but it's already on my to-fix-soon list, so I won't disable it.

@zhyatt zhyatt added this to the V24.0 milestone Jan 24, 2022
@theohax theohax self-assigned this Jan 26, 2022
@theohax theohax mentioned this pull request Feb 2, 2022
Merged
clemahieu
clemahieu previously approved these changes Feb 3, 2022
View reviewed changes
@clemahieu clemahieu force-pushed the fix-confirmation_height.election_winner_details_clearing-unit-test branch from 3a659de to 651d584 Compare February 3, 2022 13:45
@theohax
Copy link
Contributor Author

theohax commented Feb 15, 2022 •
edited
Loading

Looks like confirmation_height.election_winner_details_clearing fix got merged already (in #3679), additionally there's one more fix from @dsiganos in #3741, therefore closing this one.

@theohax theohax closed this Feb 15, 2022
@theohax theohax deleted the fix-confirmation_height.election_winner_details_clearing-unit-test branch February 15, 2022 15:14
@zhyatt zhyatt removed this from the V24.0 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu left review comments

@dsiganos dsiganos Awaiting requested review from dsiganos

@thsfs thsfs Awaiting requested review from thsfs

Assignees

@theohax theohax

Labels
bug unit test Related to a new, changed or fixed unit test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit test confirmation_height.election_winner_details_clearing intermittently failing
3 participants
@theohax @clemahieu @zhyatt