Lookup channels by node id instead of endpoints in test code #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
prs/find-channel-use-node-id
branch
from
a862b51 to
4c348cf
Compare
pwojcikdev
force-pushed
the
prs/find-channel-use-node-id
branch
from
4c348cf to
4c490f1
Compare
clemahieu
previously approved these changes
Sep 17, 2022
clemahieu
force-pushed
the
prs/find-channel-use-node-id
branch
from
4c490f1 to
5be100c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we assume we can lookup channels by their associated endpoint, however this is only because we always establish two channels per peer, one inbound and one outbound. This PR is preparation for future changes introducing bidirectional channels where one endpoint uses a random ephemeral port.
There are also a few smaller fixes that I noticed when going through code that didn't seem worthwhile to have their own PR.
TODO: It is probably a good idea to replace looking up channels by node id everywhere, but a lot of those usages are left in legacy UDP code, so this needs to wait after that part is removed.