Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UDP support from telemetry tests #3916

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Remove UDP support from telemetry tests #3916

merged 1 commit into from
Aug 29, 2022

Conversation

thsfs
Copy link
Contributor

@thsfs thsfs commented Aug 25, 2022 •
edited
Loading

Migrates or remove telemetry tests that use UDP.

  • Removed tests that are exclusive to UDP, otherwise migrated them to TCP or inproc.

Fixes issue: #3846

@thsfs thsfs marked this pull request as draft August 25, 2022 17:57
@thsfs thsfs force-pushed the remove-upd-support-from-telemetry-tests branch from 1b0efe7 to b14c99e Compare August 26, 2022 16:44
@thsfs thsfs marked this pull request as ready for review August 26, 2022 16:45
@thsfs thsfs added exclude from changelog Indicates the change is not relevant for appearing in the release changelog unit test Related to a new, changed or fixed unit test removal Indicates functionality is being removed labels Aug 26, 2022
@pwojcikdev
Copy link
Contributor

I think those outer node usages could be replaced by inproc channels, but it is not important

@thsfs thsfs merged commit db75c53 into develop Aug 29, 2022
@thsfs thsfs deleted the remove-upd-support-from-telemetry-tests branch August 29, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwojcikdev pwojcikdev pwojcikdev approved these changes

Assignees
No one assigned
Labels
exclude from changelog Indicates the change is not relevant for appearing in the release changelog removal Indicates functionality is being removed unit test Related to a new, changed or fixed unit test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thsfs @pwojcikdev