Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a very inefficient usage of database write transactions inside
vote_generator
class where we would create a new write transaction each time we wanted to generate a vote for a block. This led to stalls inside election scheduler and active transaction threads because both of those make a call toelection::generate_votes()
.To fix this I introduced a new class
processing_queue
that is a simple queue that can be configured to process batches of items. I then use this queue to process multiple voting requests at once if there is a backlog.