Block arrival activate #3970
Merged
Block arrival activate #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inserted in to the node before it is started. This ensures the added node will accurately be determined to be a rep once it is started and connects. Adding system.block_sequence slow test which constructs a system of evenly weighted PRs and ensures a sequence of blocks from a single account can be confirmed. Ongoing bootstrap is disabled during this test to detect errors in the election activation process.
… Use nano::process instead of block_processor.add in order to directly insert blocks in to the ledger.
pwojcikdev
previously approved these changes
Oct 12, 2022
dsiganos
reviewed
Oct 12, 2022
…rom announcing bootstrap blocks as they're received. This patch fixes an issue where an election might not be started on time during non-bootstrapping situations.
clemahieu
force-pushed
the
block_arrival_activate
branch
from
db77156 to
8b37c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change separates filtering block rebroadcast and election activation. The block arrival filter prevents bootstrapping nodes from rebroadcasting blocks they're bootstrapping, however, the logic would also prevent elections from being started on time in some situations.