Create upper bound for geos and bump PROJ #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this in preference of skipping tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to hotfix some critical issues with dependencies that came up here: #476 . They relate to GEOS and PROJ libraries.
This PR sets an upper bound
geos<3.9.0to avoid a confirmed bug in GEOS libgeos/geos#408 .This PR also updates a Wave Energy test for PROJ 7.2.0 and sets a GDAL lower bound to
3.2.1that will grab PROJ 7.2.0+. I believe this precision difference is due to improvements on PROJ handling coordindate transformations.NOTE: There are still conda builds of GDAL 3.2.1 that support PROJ < 7.2.0, but I think it'll grab the later version for us consistently. We just have no direct handle on PROJ without using conda.
Checklist
Updated HISTORY.rst (if these changes are user-facing)
Updated the user's guide (if needed)