Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CommandOption/Argument.value to return DefaultValue #420

Merged
merged 6 commits into from
Jan 11, 2021

Conversation

natemcmaster
Copy link
Owner

Follow-up to #389. This updates CommandOption.Value and CommandArgument.Value to return DefaultValue when nothing has been passed on command line.

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #420 (8cd2a2a) into feature/default-value (9ff8c22) will increase coverage by 0.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           feature/default-value     #420      +/-   ##
=========================================================
+ Coverage                  67.17%   67.76%   +0.58%     
=========================================================
  Files                        105      105              
  Lines                       3260     3282      +22     
=========================================================
+ Hits                        2190     2224      +34     
+ Misses                      1070     1058      -12     
Impacted Files Coverage Δ
src/CommandLineUtils/CommandArgument.cs 94.73% <100.00%> (+6.50%) ⬆️
src/CommandLineUtils/CommandArgument{T}.cs 96.66% <100.00%> (+25.23%) ⬆️
src/CommandLineUtils/CommandOption.cs 69.01% <100.00%> (+0.89%) ⬆️
src/CommandLineUtils/CommandOption{T}.cs 96.66% <100.00%> (+25.23%) ⬆️
.../CommandLineUtils/Internal/CommandLineProcessor.cs 83.04% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff8c22...8cd2a2a. Read the comment docs.

@natemcmaster natemcmaster merged commit 8c2a3d2 into feature/default-value Jan 11, 2021
@natemcmaster natemcmaster deleted the default-value2 branch January 11, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant