Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal instant functions #106

Merged
merged 12 commits into from
Aug 8, 2023
Merged

Temporal instant functions #106

merged 12 commits into from
Aug 8, 2023

Conversation

angrykoala
Copy link
Member

@angrykoala angrykoala commented Aug 3, 2023

This one has a lot of repeated code, not sure if there is a way of making this more susccint whilst maintaining the doc comments

@angrykoala angrykoala requested a review from a-alle August 3, 2023 16:23
@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

🦋 Changeset detected

Latest commit: 22319de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/cypher-builder Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@angrykoala angrykoala linked an issue Aug 3, 2023 that may be closed by this pull request
13 tasks
@angrykoala angrykoala requested a review from mjfwebb August 8, 2023 09:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@mjfwebb mjfwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I can't see any problems

@angrykoala angrykoala merged commit d44561f into main Aug 8, 2023
@angrykoala angrykoala deleted the temporal-instant-functions branch August 8, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement missing Cypher functions
2 participants