-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern config with variables #310
Conversation
🦋 Changeset detectedLatest commit: f766f84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
688e4f9
to
d0068fa
Compare
519644d
to
0aab62f
Compare
src/pattern/Pattern.ts
Outdated
super(node); | ||
|
||
// Emulates not having a variable if the config option is passed without one | ||
if (!(nodeConfig instanceof NodeRef) && !nodeConfig.variable) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this and assign this.withVariable
as Boolean(nodeConfig.variable)
in the branch condition below
1a20c1e
to
98a8b2f
Compare
|
This PR adds non-breaking support for #300, allowing for plain variables to be used in Cypher Patterns
For example:
instead of the current: