-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for offset #420
Conversation
🦋 Changeset detectedLatest commit: 77d8795 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -72,16 +77,19 @@ export class OrderBy extends CypherASTNode { | |||
} | |||
|
|||
class Skip extends CypherASTNode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another solution could be to have Offset
that extends Skip and removing the flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts? This is quite internal, and I feel that this solution is simple enough for this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unbiased honestly, I think we will have some cases similar in the future, where a GQL syntax will be an alias of an existing syntax, I would handle all the aliases in the same way, but we handle them just like this as well!
Add support for
OFFSET
alias forSKIP
: