Add support for trim expressions #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 32c58b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
angrykoala
force-pushed
the
379-support-for-both-x-from-xxhelloxx-syntax-on-trim
branch
from
e0835e3 to
d90d4d5
Compare
angrykoala
force-pushed
the
379-support-for-both-x-from-xxhelloxx-syntax-on-trim
branch
from
d90d4d5 to
8723c78
Compare
|
MacondoExpress
approved these changes
Jan 9, 2025
| private readonly trimChar: Expr; | ||
| private readonly input: Expr; | ||
|
|
||
| constructor(typeOrInput: "BOTH" | "LEADING" | "TRAILING", trimChar: Expr, input: Expr) { |
There was a problem hiding this comment.
Suggested change
| constructor(typeOrInput: "BOTH" | "LEADING" | "TRAILING", trimChar: Expr, input: Expr) { | |
| constructor(typeOrInput: "BOTH" | "LEADING" | "TRAILING", trimChars: Expr, input: Expr) { |
Nitpick: I would put chars as plural to reflect better the usage
MacondoExpress
approved these changes
Jan 9, 2025
| @@ -131,4 +131,12 @@ describe("String Functions", () => { | |||
| param1: "NFC", | |||
| }); | |||
| }); | |||
|
|
|||
| test("trim with trim expression", () => { | |||
There was a problem hiding this comment.
I believe the simple case is not tested such as:
trim(' hello ')
There was a problem hiding this comment.
That is already tested for the normal trim case, along with other functions of 1 parameter
angrykoala
deleted the
379-support-for-both-x-from-xxhelloxx-syntax-on-trim
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for trim expressions in
trim: