Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwind create #2115

Merged
merged 61 commits into from
Nov 1, 2022
Merged

Unwind create #2115

merged 61 commits into from
Nov 1, 2022

Conversation

MacondoExpress
Copy link
Contributor

@MacondoExpress MacondoExpress commented Sep 20, 2022

Description

PR that holds the implementation behind the rfc-024-unwind-create.md

Issue

Closes #1253

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022

🦋 Changeset detected

Latest commit: 0a137a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@neo4j/cypher-builder Patch
@neo4j/graphql Minor
@neo4j/graphql-toolbox Patch
@neo4j/graphql-plugin-subscriptions-amqp Major
@neo4j/graphql-ogm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Sep 20, 2022

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@neo4j-team-graphql neo4j-team-graphql added the documentation Improvements or additions to documentation label Oct 28, 2022
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly running out of time and focus to review this on a Friday. The outcome is obviously looking great! However, I do have concerns about the approach of using the visitor pattern for the solution here - I think it makes it quite an inaccessible part of the codebase unless you are intimately familiar with it (I'm finding it quite complex to review). I don't think our parsing is at a complex enough level that we need to leverage such a pattern. Let's discuss next week!

@MacondoExpress MacondoExpress merged commit 8de9f02 into dev Nov 1, 2022
@angrykoala angrykoala deleted the unwind-create branch November 25, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create operations generates a gigantic cypher query for batch inserts
4 participants