-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unwind create #2115
Unwind create #2115
Conversation
Feature/unwind create
🦋 Changeset detectedLatest commit: 0a137a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/graphql/src/translate/cypher-builder/CypherBuilder.test.ts
Outdated
Show resolved
Hide resolved
packages/graphql/tests/tck/operations/batch/batch-create.test.ts
Outdated
Show resolved
Hide resolved
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
packages/graphql/src/translate/cypher-builder/CypherBuilder.test.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/cypher-builder/clauses/ProcedureCall.ts
Outdated
Show resolved
Hide resolved
packages/graphql/tests/tck/operations/batch/batch-create.test.ts
Outdated
Show resolved
Hide resolved
packages/graphql/tests/tck/operations/batch/temporary-test.test.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/ConnectAST.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/ConnectAST.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/ConnectAST.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/ConnectAST.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/ConnectAST.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/ConnectOrCreateAST.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/ConnectOrCreateAST.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/ConnectOrCreateAST.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/types.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/ConnectOrCreateAST.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/GraphQLInputAST/CreateAST.ts
Show resolved
Hide resolved
packages/graphql/src/translate/batch-create/unwind-create-visitors/UnwindCreateVisitor.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: angrykoala <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly running out of time and focus to review this on a Friday. The outcome is obviously looking great! However, I do have concerns about the approach of using the visitor pattern for the solution here - I think it makes it quite an inaccessible part of the codebase unless you are intimately familiar with it (I'm finding it quite complex to review). I don't think our parsing is at a complex enough level that we need to leverage such a pattern. Let's discuss next week!
packages/graphql/tests/tck/connections/projections/create.test.ts
Outdated
Show resolved
Hide resolved
packages/graphql/tests/integration/unwind-create/unwind-create.int.test.ts
Show resolved
Hide resolved
Co-authored-by: angrykoala <[email protected]>
Co-authored-by: Darrell Warde <[email protected]>
Co-authored-by: Darrell Warde <[email protected]>
Co-authored-by: Darrell Warde <[email protected]>
Co-authored-by: Darrell Warde <[email protected]>
…t export the compileIfNotExists
Description
PR that holds the implementation behind the rfc-024-unwind-create.md
Issue
Closes #1253
Checklist
The following requirements should have been met (depending on the changes in the branch):