Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypher Builder - export Cypher.Property #3106

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

darrellwarde
Copy link
Contributor

@darrellwarde darrellwarde commented Mar 28, 2023

Description

Note

Please provide a description of the work completed in this PR below

Cypher.PropertyRef is currently exposed as a type only. This exports Cypher.Property in full, which is a requirement for Authorization.

Complexity

Note

Please provide an estimated complexity of this PR of either Low, Medium or High

Complexity: Low

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

🦋 Changeset detected

Latest commit: d776fa1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@neo4j/cypher-builder Minor
@neo4j/graphql Patch
@neo4j/graphql-toolbox Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@darrellwarde
Copy link
Contributor Author

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pull-requests.yml:code-scanning. As part of the setup process, we have scanned this repository and found 6 existing alerts. Please check the repository Security tab to see all alerts.

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Mar 28, 2023

Thanks for the UI updates.

The UI has now been torn down - reopening this PR will republish it.

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Mar 28, 2023

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3403 3403 33 49 1134
aggregations.NestedAggregation 14551 14551 66 94 2174
aggregations.AggregationWithWhere 11979 11979 41 59 2174
aggregations.AggregationWhereWithinNestedRelationships 22116987 22116987 3243 2951 2008534
aggregations.AggregationWhereWithinNestedConnections 22116987 22116987 2826 2852 2008534
aggregations.NestedCountFromMovieToActors 9734 9734 45 47 2174
aggregations.NestedCountFromActorsToMovie 9937 9937 43 52 2174
aggregations.DeeplyNestedCount 13070333 13070329 4340 4613 2008534
batch-create.BatchCreate 4200 4200 217 177 600
connect.createAndConnect 14424 14424 154 266 3003
connections.Connection 14082 14082 57 67 2174
connections.NestedConnection 41462 41462 111 121 4516
connections.ConnectionWithSort 2282 2282 57 66 1040
connections.ConnectionWithSortAndCypher 2282 2282 164 264 1040
create.SimpleMutation 7 7 51 88 1
cypher-directive.TopLevelCypherDirective 116092 116092 677 633 12241
cypher-directive.TopLevelCypherDirectiveWithColumnName 147609 147609 157 201 12241
delete.SimpleDelete 19401 19401 237 352 1040
delete.NestedDeleteInUpdate 22200 22200 135 186 2040
2925.SingleRelationshipFilter 6468 6468 55 41 1040
2925.NestedSingleRelationshipFilter 22900 22900 63 82 2174
2925.SingleRelationshipRequiredFilter 3450 3450 23 27 1134
2925.NestedSingleRelationshipRequiredFilter 9383 9383 51 53 1040
query.SimpleQuery 15160 15160 41 51 2174
query.QueryWhere 9706 9696 31 37 2165
query.SimpleQueryWithNestedWhere 9884 9874 46 53 2165
query.Nested 10092037 10092037 9732 9770 2008534
query.NestedWithFilter 40401 40401 91 142 4511
query.OrFilterOnRelationships 42776 43786 148 208 1813
query.OrFilterOnRelationshipsAndNested 36879 37272 173 240 1813
query.QueryWithNestedIn 13838 13599 49 62 1364
query.NestedConnectionWhere 9834 9834 114 62 2174
query.DeeplyNestedConnectionWhere 10074 10044 74 80 2174
query.DeeplyNestedWithRelationshipFilters 19332 19320 135 232 1658
query.NestedWithRelationshipSingleFilters 3024400 3024400 764 783 1003942
query.Fulltext 96 96 26 29 16
query.FulltextWithNestedQuery 587 587 47 44 84
sorting.SortMultipleTypes 2513 2513 59 67 1040
sorting.SortMultipleTypesWithCypherWithCypher 1545 1430 164 215 1040
sorting.SortOnNestedFields 14082 14082 47 52 2174
sorting.SortDeeplyNestedFields 42196 42196 83 94 4516
sorting.SortWithTopLevelCypher 2119 2119 96 166 1040
unions.SimpleUnionQuery 321 321 57 71 35
unions.SimpleUnionQueryWithMissingFields 293 293 56 61 35
unions.NestedUnion 410637 410637 284 291 33033
unions.NestedUnionWithMissingFields 384611 384611 278 289 33033
update.NestedUpdate 2119 2119 57 106 1040

Old Schema Generation: 30.674s
Schema Generation: 27.926s
Old Subgraph Schema Generation: 44.337s
Subgraph Schema Generation: 41.309s

@angrykoala
Copy link
Member

@angrykoala, should https://github.com/neo4j/graphql/pull/3106/files#diff-644d9c8b33dc3e7e560dacb7b2025d81ca04e8f22c5fa3baa58010b5bdd24250R41 return type be Reference to match the type of the member?

Yeah, I think that's a good idea. Good catch

@darrellwarde
Copy link
Contributor Author

@angrykoala, should https://github.com/neo4j/graphql/pull/3106/files#diff-644d9c8b33dc3e7e560dacb7b2025d81ca04e8f22c5fa3baa58010b5bdd24250R41 return type be Reference to match the type of the member?

Yeah, I think that's a good idea. Good catch

I changed the type, but not the name of the method, so it's still called variable() - is this okay?

@darrellwarde darrellwarde enabled auto-merge (squash) March 28, 2023 14:59
@darrellwarde darrellwarde merged commit bfae630 into neo4j:dev Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants