Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inequality operator (<>) in CypherBuilder #3154

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

angrykoala
Copy link
Member

Description

Add support for inequality operator (<>):

Cypher.neq(new Cypher.Param(1), new Cypher.Param(2); // 1 <> 2

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023

🦋 Changeset detected

Latest commit: 0afb1de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/cypher-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pull-requests.yml:code-scanning. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Apr 4, 2023

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3403 3403 43 58 1134
aggregations.NestedAggregation 14551 14551 110 121 2174
aggregations.AggregationWithWhere 11979 11979 62 84 2174
aggregations.AggregationWhereWithinNestedRelationships 22116987 22116987 4480 4927 2008534
aggregations.AggregationWhereWithinNestedConnections 22116987 22116987 4427 4302 2008534
aggregations.NestedCountFromMovieToActors 9734 9734 51 65 2174
aggregations.NestedCountFromActorsToMovie 9937 9937 53 67 2174
aggregations.DeeplyNestedCount 13070333 13070329 6473 6013 2008534
batch-create.BatchCreate 4200 4200 180 278 600
connect.createAndConnect 14424 14424 262 353 3003
connections.Connection 14082 14082 143 82 2174
connections.NestedConnection 41468 41462 162 142 4516
connections.ConnectionWithSort 2282 2282 90 118 1040
connections.ConnectionWithSortAndCypher 2282 2282 298 437 1040
create.SimpleMutation 7 7 71 108 1
cypher-directive.TopLevelCypherDirective 116092 116092 890 801 12241
cypher-directive.TopLevelCypherDirectiveWithColumnName 147609 147609 255 243 12241
delete.SimpleDelete 19401 19401 522 609 1040
delete.NestedDeleteInUpdate 22200 22200 262 266 2040
2925.SingleRelationshipFilter 6468 6468 75 56 1040
2925.NestedSingleRelationshipFilter 22900 22900 122 112 2174
2925.SingleRelationshipRequiredFilter 3450 3450 37 41 1134
2925.NestedSingleRelationshipRequiredFilter 9383 9383 74 66 1040
query.SimpleQuery 15160 15160 65 60 2174
query.QueryWhere 9685 9725 49 46 2159
query.SimpleQueryWithNestedWhere 9863 9903 62 78 2159
query.Nested 10092037 10092037 12343 12914 2008534
query.NestedWithFilter 40401 40401 160 166 4511
query.OrFilterOnRelationships 41378 43303 248 309 1207
query.OrFilterOnRelationshipsAndNested 35285 37462 284 317 1207
query.QueryWithNestedIn 13281 13236 74 80 1180
query.NestedConnectionWhere 9834 9834 76 189 2174
query.DeeplyNestedConnectionWhere 9834 9943 99 309 2174
query.DeeplyNestedWithRelationshipFilters 19032 19188 195 211 1564
query.NestedWithRelationshipSingleFilters 3024400 3024400 1080 981 1003942
query.Fulltext 96 96 33 45 16
query.FulltextWithNestedQuery 587 587 60 97 84
sorting.SortMultipleTypes 2513 2513 95 114 1040
sorting.SortMultipleTypesWithCypherWithCypher 1506 1469 299 382 1040
sorting.SortOnNestedFields 14082 14082 68 72 2174
sorting.SortDeeplyNestedFields 42196 42196 133 127 4516
sorting.SortWithTopLevelCypher 2119 2119 224 253 1040
unions.SimpleUnionQuery 321 321 92 96 35
unions.SimpleUnionQueryWithMissingFields 293 293 97 90 35
unions.NestedUnion 410637 410637 408 511 33033
unions.NestedUnionWithMissingFields 384611 384611 357 394 33033
update.NestedUpdate 2119 2119 83 91 1040

Old Schema Generation: 56.035s
Schema Generation: 56.729s
Old Subgraph Schema Generation: 1:15.641 (m:ss.mmm)
Subgraph Schema Generation: 1:14.943 (m:ss.mmm)

@darrellwarde
Copy link
Contributor

Just a test comment for CLA Assistant...

Copy link
Contributor

@MacondoExpress MacondoExpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angrykoala angrykoala merged commit b276bba into neo4j:dev Apr 4, 2023
@angrykoala angrykoala deleted the cypher-builder-neq branch April 4, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants