Extract configuration into JSON-file #54 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at5500
approved these changes
Jun 22, 2022
added 3 commits
June 23, 2022 21:31
at5500
approved these changes
Jun 29, 2022
| let path = file?.path(); | ||
| match read_keypair_file(path.clone()) { | ||
| Ok(keypair) => voter_keypairs.push(keypair), | ||
| Err(err) => println!("Skip '{}' due to {}", path.display(), err), |
There was a problem hiding this comment.
Maybe we change println! macros to info! from Tokio Tracing?
There was a problem hiding this comment.
We can do it in a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration file contains all parameters used to create the right environment.
Pubkeys can be specified as values or filename to the keypair (it is actually for the
creator-keypair when creating the environment).