Add smart contract code compatibility checklist document #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukanyaparashar
changed the title
|
|
||
| ### Usage of `multicall` methods | ||
|
|
||
| The smart contracts having `multicall` methods that includes more than one address or migration methods to recreate state from another chain results in exceeding the 64 accounts limit. This situation can be avoided by calling these methods in batches. |
There was a problem hiding this comment.
@sukanyaparashar please explain here that the 64 accounts limit does not mean 64 addresses on Solidity. We do also have 7 default accounts that used for the transaction execution and this automatically makes a limit of 57 Solidity addresses that can be included in a single transaction. The number can be even smaller if there are more internal calls between contracts.
mnedelchev-vn
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
@sukanyaparashar I've looked at the changes and they're ok, I only removed some of the text about the 64 accounts limits. We will bring more details in this section after neon_emulate test is done.
OlehSyzonov
reviewed
Apr 10, 2024
Co-authored-by: OlehSyzonov <[email protected]>
Co-authored-by: OlehSyzonov <[email protected]>
Co-authored-by: OlehSyzonov <[email protected]>
Co-authored-by: OlehSyzonov <[email protected]>
OlehSyzonov
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a smart contract code compatibility checklist document.