fix(eslint): update openDoc os call for windows #3615
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
lua/lspconfig/configs/eslint.lua
Outdated
| @@ -136,7 +136,7 @@ return { | |||
| end | |||
| local sysname = vim.loop.os_uname().sysname | |||
| if sysname:match 'Windows' then | |||
There was a problem hiding this comment.
All of this should be replaced with a single call to vim.ui.open(). That handles all OSes automatically.
There was a problem hiding this comment.
I think that was added in 0.10. I can make the change.
Can i make the change? The README in this repo says 0.9+.
There was a problem hiding this comment.
We'll update that soon. But anyway, if people want to use this command, they need Nvim 0.10
There was a problem hiding this comment.
NVIM v0.10.4
Build type: Release
LuaJIT 2.1.1713484068
system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "C:/Program Files (x86)/nvim/share/nvim"
vim.ui.open when run from vim environment doesn't do anything.
and in my lsp, the second argument is simply not present.
i have lua 5.4.7 installed via msys2
There was a problem hiding this comment.
- it works for files doesn't work for urls
There was a problem hiding this comment.
vim.ui.open() absolutely works for URLs. Try this:
:lua vim.ui.open('https://google.com')
There was a problem hiding this comment.
why are you passing cmd=osurl ? don't do that.
There was a problem hiding this comment.
Hi, turns out it was an issue with qutebrowser. works with edge on windows
Kushal-Chandar
force-pushed
the
eslint-open-doc-fix
branch
from
c09830a to
939dc87
Compare
Problem: os.execute misinterprets quoted url as window title Solution: replace it with vim.ui.open()
Kushal-Chandar
force-pushed
the
eslint-open-doc-fix
branch
from
939dc87 to
ffc08b9
Compare
Problem:
os.execute misinterprets quoted url as window title
Solution:
add an empty title argument