Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add owner role support #1340

Merged
merged 10 commits into from
Dec 1, 2023
Merged

add owner role support #1340

merged 10 commits into from
Dec 1, 2023

Conversation

mlsmaycon
Copy link
Collaborator

@mlsmaycon mlsmaycon commented Nov 29, 2023

Describe your changes

This PR adds support to Owner roles.

The owner role has a similar access level as the admin, but it has the power to delete the account.

Besides that, the role has the following constraints:

  • The role can only be transferred. So, only a user with the owner role can transfer the owner role to a new user
  • It can't be assigned to users being invited
  • It can't be assigned to service users

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@mlsmaycon mlsmaycon marked this pull request as ready for review December 1, 2023 08:37
@mlsmaycon mlsmaycon requested a review from surik December 1, 2023 16:21
@mlsmaycon mlsmaycon merged commit d7efea7 into main Dec 1, 2023
@mlsmaycon mlsmaycon deleted the add-owner-role branch December 1, 2023 16:24
surik pushed a commit that referenced this pull request Dec 14, 2023
This PR adds support to Owner roles.

The owner role has a similar access level as the admin, but it has the power to delete the account.

Besides that, the role has the following constraints:

- The role can only be transferred. So, only a user with the owner role can transfer the owner role to a new user
- It can't be assigned to users being invited
- It can't be assigned to service users
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
This PR adds support to Owner roles.

The owner role has a similar access level as the admin, but it has the power to delete the account.

Besides that, the role has the following constraints:

- The role can only be transferred. So, only a user with the owner role can transfer the owner role to a new user
- It can't be assigned to users being invited
- It can't be assigned to service users
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
This PR adds support to Owner roles.

The owner role has a similar access level as the admin, but it has the power to delete the account.

Besides that, the role has the following constraints:

- The role can only be transferred. So, only a user with the owner role can transfer the owner role to a new user
- It can't be assigned to users being invited
- It can't be assigned to service users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants