Refactor firewall manager check #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems don't play nice with a test chain So we dropped the idea, and instead we just check for the filter table With this check we might face a case where iptables is selected once and on next netbird up/down it will go back to using nftables
lixmal
previously approved these changes
May 25, 2024
lixmal
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Some systems don't play nice with a test chain, so we dropped the idea, and instead, we just checked for the filter table
With this check, we might face a case where iptables is selected once, and on the next netbird up/down, it will go back to using nftables
Issue ticket number and link
Checklist