Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MACOSX_DEPLOYMENT_TARGET environment to control GUI build target #2221

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

mlsmaycon
Copy link
Collaborator

@mlsmaycon mlsmaycon commented Jul 1, 2024

Describe your changes

Add MACOSX_DEPLOYMENT_TARGET and MACOS_DEPLOYMENT_TARGET to target build compatible with macOS 11+ instead of relying on the builder's local Xcode version.

Issue ticket number and link

fixes #2218

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@mlsmaycon mlsmaycon changed the title use cgo flags for darwin build add MACOSX_DEPLOYMENT_TARGET environment to control GUI build target Jul 1, 2024
Copy link

sonarqubecloud bot commented Jul 1, 2024

@mlsmaycon mlsmaycon marked this pull request as ready for review July 1, 2024 15:16
@mlsmaycon mlsmaycon merged commit 6857734 into main Jul 1, 2024
23 checks passed
@mlsmaycon mlsmaycon deleted the fix/macos-gui-build branch July 1, 2024 15:59
lixmal pushed a commit that referenced this pull request Jul 22, 2024
…2221)

Add MACOSX_DEPLOYMENT_TARGET and MACOS_DEPLOYMENT_TARGET to target build compatible with macOS 11+ instead of relying on the builder's local Xcode version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netbird isn't available for MacOS 12?
2 participants