Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get client ui locale on windows natively #2251

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Get client ui locale on windows natively #2251

merged 5 commits into from
Jul 12, 2024

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Jul 10, 2024 •
edited
Loading

Describe your changes

Get the windows client ui local without powershell

Issue ticket number and link

#2192
We're getting the locales on windows via powershell, that leads to a popup before starting netbird-ui.

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@lixmal
Copy link
Contributor Author

lixmal commented Jul 10, 2024

@Yxnt Can you verify that this PR doesn't affect the functionality please?

@lixmal lixmal force-pushed the fix/windows-powershell-popup branch from 8900860 to 75b49dc Compare July 10, 2024 10:38
@lixmal lixmal force-pushed the fix/windows-powershell-popup branch from dbc0710 to 7a79d29 Compare July 10, 2024 11:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Yxnt
Copy link
Contributor

Yxnt commented Jul 10, 2024 •
edited
Loading

@Yxnt Can you verify that this PR doesn't affect the functionality please?

i will check it later. :)

@mlsmaycon
Copy link
Collaborator

@Yxnt Can you verify that this PR doesn't affect the functionality please?

i will check it later. :)

Hello @Yxnt, have you got the chance to validate the fix? We are planing to release a new version today with this.

@Yxnt
Copy link
Contributor

Yxnt commented Jul 12, 2024

@Yxnt Can you verify that this PR doesn't affect the functionality please?

i will check it later. :)

Hello @Yxnt, have you got the chance to validate the fix? We are planing to release a new version today with this.

Sorry I've been busy the last couple of days, I've just looked at it and there's no problem, and the run window doesn't pop up when I run it either

Yxnt
Yxnt approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@Yxnt Yxnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is ok.

@mlsmaycon
Copy link
Collaborator

@Yxnt Can you verify that this PR doesn't affect the functionality please?

i will check it later. :)

Hello @Yxnt, have you got the chance to validate the fix? We are planing to release a new version today with this.

Sorry I've been busy the last couple of days, I've just looked at it and there's no problem, and the run window doesn't pop up when I run it either

no worries, thanks for taking the time to double check on your end.

@mlsmaycon mlsmaycon merged commit 89df6e7 into main Jul 12, 2024
22 checks passed
@mlsmaycon mlsmaycon deleted the fix/windows-powershell-popup branch July 12, 2024 06:25
hurricanehrndz added a commit to hurricanehrndz/netbird that referenced this pull request Jul 15, 2024
@hurricanehrndz
Merge remote-tracking branch 'upstream/main'
ba16d76 
* upstream/main:
  Add batch save/update for groups and users (netbirdio#2245)
  Limit GUI process execution to one per UID (netbirdio#2267)
  Add logging option for wg device (netbirdio#2271)
  fix 2260: fallback serial to Board (netbirdio#2263)
  Support DNS routes on iOS (netbirdio#2254)
  Fix parameter limit issue for Postgres store (netbirdio#2261)
  Bump google.golang.org/grpc from 1.64.0 to 1.64.1 (netbirdio#2248)
  Get client ui locale on windows natively (netbirdio#2251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsmaycon mlsmaycon mlsmaycon approved these changes

@Yxnt Yxnt Yxnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lixmal @Yxnt @mlsmaycon