New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid empty domain overwrite #2252

Merged

pascal-fischer merged 1 commit into main from fix/empty-domain-overwrite

Jul 10, 2024

Contributor

pascal-fischer commented Jul 10, 2024

Describe your changes

We noticed occasional overwrites on the domain field with empty strings which was causing unneccessary updates. This PR checks this.

Issue ticket number and link

Checklist

Is it a bug fix
Is a typo/documentation fix
Is a feature enhancement
It is a refactor
Created tests that fail without the change (if possible)
Extended the README / documentation, if necessary


          check for empty domain

34ccc8c

sonarqubecloud bot commented Jul 10, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mlsmaycon approved these changes

View reviewed changes

pascal-fischer merged commit e8c2faf into main

22 checks passed

pascal-fischer deleted the fix/empty-domain-overwrite branch

July 10, 2024 12:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet