Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer only Device Code Flow on FreeBSD #2389

Merged

Conversation

skillcoder
Copy link
Contributor

@skillcoder skillcoder commented Aug 4, 2024

Describe your changes

Issue ticket number and link

#2384

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@skillcoder skillcoder marked this pull request as draft August 4, 2024 20:18
@skillcoder skillcoder marked this pull request as ready for review August 4, 2024 20:29
@mlsmaycon mlsmaycon merged commit d56dfae into netbirdio:main Aug 4, 2024
21 checks passed
@avg-I
Copy link

avg-I commented Aug 26, 2024

I am not sure what was the rationale for this change.
It broke my ability to login via a browser.

I am running netbird from command line (terminal application) in a FreeBSD desktop environment (KDE in my case).

@avg-I
Copy link

avg-I commented Aug 26, 2024

I looked at #2384, but I am not convinced.
NetBird on FreeBSD should provide the same experience as other platforms.
People who need to run NetBird in special environments (headless, etc) need to take extra steps to get their configuration.
But "common users" should get something working out of the box.

Please consider reverting.

@avg-I
Copy link

avg-I commented Aug 26, 2024

FWIW, command-line netbird 0.28.7 and 0.28.8 (with this change reverted) just work for me without any special patches.
I build netbird with simple commands like:

cd client
go build -o netbird -ldflags '-X github.com/netbirdio/netbird/version.version=0.28.8

That's it.

I understand that there is a lot of work going on to integrate NetBird into "appliances" like OPNSense.
I appreciate it, but please keep the desktop experience working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants