Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] Add transaction to addPeer #2469

Merged
merged 27 commits into from
Sep 16, 2024
Merged

Conversation

pascal-fischer
Copy link
Contributor

@pascal-fischer pascal-fischer commented Aug 22, 2024

Describe your changes

This PR removes the GetAccount and SaveAccount operations from the AddPeer and instead makes use of gorm.Transaction to add the new peer.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@pascal-fischer pascal-fischer changed the title fix/add-transaction-to-login [management] Add transaction to addPeer Aug 22, 2024
@pascal-fischer pascal-fischer marked this pull request as ready for review August 26, 2024 08:50
Copy link

@mlsmaycon mlsmaycon merged commit 6c50b0c into main Sep 16, 2024
21 checks passed
@mlsmaycon mlsmaycon deleted the fix/add-transaction-to-login branch September 16, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants