feat: change default node version to v22 #5958
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrstork
force-pushed
the
update-default-node-version
branch
3 times, most recently
from
f788877 to
82a771e
Compare
mrstork
force-pushed
the
update-default-node-version
branch
from
82a771e to
e8a73f4
Compare
pieh
previously approved these changes
Feb 18, 2025
mrstork
commented
Feb 20, 2025
|
|
||
| this.env = { | ||
| AWS_LAMBDA_JS_RUNTIME: 'nodejs18.x', | ||
| NODE_VERSION: '18', |
There was a problem hiding this comment.
Nuxt has no strict requirement for node 18 and prefers LTS (or 22)
https://github.com/nuxt/nuxt/blob/main/packages/nuxt/package.json#L155-L157
mrstork
commented
Feb 20, 2025
| @@ -22,8 +22,4 @@ export class Observable extends BaseFramework implements Framework { | |||
| light: '/logos/observable/default.svg', | |||
| dark: '/logos/observable/default.svg', | |||
| } | |||
|
|
|||
| env = { | |||
| NODE_VERSION: '20', | |||
There was a problem hiding this comment.
No requirement for 20 specifically, supports > 18
https://github.com/observablehq/framework/blob/main/package.json#L139-L141
mrstork
force-pushed
the
update-default-node-version
branch
from
6f462c3 to
0ae62a7
Compare
|
Redwood is the only framework with a specific requirement for v20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of FRB-1505
Change needs a coordinated release, please do not merge yet
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)