Regenerate go client using go-swagger 0.16.0 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiko713
force-pushed
the
regenerate-go-client
branch
from
4e9519c to
a811584
Compare
bcomnes
approved these changes
Sep 7, 2018
bcomnes
reviewed
Sep 7, 2018
| @@ -16,7 +16,7 @@ deps: ## Download dependencies. | |||
| go get -u github.com/golang/dep/cmd/dep && cd ./go && dep ensure | |||
|
|
|||
| generate: validate ## Generate the API Go client and the JSON document for the UI. | |||
| swagger generate client -A netlify -f swagger.yml -t go -c plumbing | |||
| swagger generate client -A netlify -f swagger.yml -t go -c plumbing --with-flatten=full | |||
There was a problem hiding this comment.
This has to do with the flattening of the different models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What title says. This generates some user operations, since it was added recently to swagger.yml but regeneration didn't happen at that time.
There are many changes but looks like they're mostly:
Validate--with-flatten=fullsince it was the "default" with 0.12.0 (previous version), this allows upgrading the version to cause minimal changes (also test passes)Overall this looks pretty safe to me, but I'm... not really familiar with this, so any advice for the way to test it out or proving that this is okay is welcome!