add delete site to porcelain client #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for open-api ready! Built with commit bb9d445 |
mraerino
reviewed
Jan 22, 2020
.gitignore
Outdated
| .gobincache | ||
| .idea/* |
There was a problem hiding this comment.
please put those into your global gitignore file, not in the repo. I know we have .vscode in there, but this should not prove as an example.
|
@mraerino Made the requested changes. Can I get another review? |
|
@mraerino can I get another review? |
|
@mraerino can I get another review? |
mraerino
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #98