Fixed Alpaca broker bug for loading existing orders

neurallayer · Jun 18, 2024 · ce3a957 · ce3a957
1 parent 706fc03
commit ce3a957
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/roboquant-alpaca/src/main/kotlin/org/roboquant/alpaca/AlpacaBroker.kt b/roboquant-alpaca/src/main/kotlin/org/roboquant/alpaca/AlpacaBroker.kt
@@ -127,6 +127,7 @@ class AlpacaBroker(
     private fun syncOrders() {
         _account.orders.forEach {
             if (it.open) {
+                // println("orderid=${it.order.id}")
                 val orderId = UUID.fromString(it.order.id)
                 val alpacaOrder = alpacaAPI.trader().orders().getOrderByOrderID(orderId, false)
                 logger.debug { "open order id=$orderId alpaca-order=$alpacaOrder" }
@@ -209,7 +210,7 @@ class AlpacaBroker(
             OrderType.TRAILING_STOP -> TrailOrder(asset, Size(qty), order.trailPercent!!.toDouble())
             else -> throw UnsupportedException("unsupported order type for order $order")
         }
-
+        rqOrder.id = order.id ?: throw UnsupportedException("Unsupported order $order because no known id")
         return rqOrder
     }
 

diff --git a/roboquant/src/main/kotlin/org/roboquant/Roboquant.kt b/roboquant/src/main/kotlin/org/roboquant/Roboquant.kt
@@ -50,12 +50,10 @@ data class Roboquant(
     val broker: Broker = SimBroker()
 ) {
 
-
-    private val kotlinLogger = Logging.getLogger(Roboquant::class)
-
+    private val logger = Logging.getLogger(Roboquant::class)
 
     init {
-        kotlinLogger.debug { "Created new roboquant instance=$this" }
+        logger.debug { "Created new roboquant instance=$this" }
     }
 
     /**
@@ -139,7 +137,6 @@ data class Roboquant(
 
 }
 
-
 /**
  * Blocking version of runAsync
  */