Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/press7-70 exclude from cache #27

Merged
merged 30 commits into from
Jan 8, 2025
Merged

Enhance/press7-70 exclude from cache #27

merged 30 commits into from
Jan 8, 2025

Conversation

geckod22
Copy link
Contributor

Proposed changes

Added a new option for cache exclusion in Performance module

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This is the option
imagen

geckod22 and others added 18 commits November 6, 2024 13:27
@geckod22
possible cache fix on option update
91a1fca
@geckod22
added restApi class to update the option
b3a6f49
New: Cache Exclusion option
e3c3fb6
Merge branch 'enhance/PRESS7-70-exclude-from-cache' of https://github…
fe7408b 
….com/newfold-labs/wp-module-performance into enhance/PRESS7-70-exclude-from-cache
@geckod22
register the api and add the value to runtime
04b837a
@geckod22
fixed string
449116b
@geckod22
moved getDefaultCacheExclusions function to functions file
9a7cd89
@geckod22
updated js component
ddb7674
Tweak: show "save" button only if the current value has been edited
6b56ef1
Tweak: renamed option in "newfold_cache_exclusion"
3586b38 
Tweak: use constant OPTION_CACHE_EXCLUSION
Exclude cache (file and browser)
54061e4
Tweak: manage cache exclusion using existing method "addRules"
f7257a9
@geckod22
added porting function to manage exclusion option update
a9c77da
Tweak: write htaccess file according to page exclusion
a811cbc
@geckod22
some fixies and phpcs
d9bd0df
@geckod22
smaller textarea field
0cd4452
@geckod22
phpcs fixes
278168a
@geckod22
minor js fix
a58907c
arunshenoy99
arunshenoy99 reviewed Dec 29, 2024
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geckod22 let's update this PR by merging main into it. Looks like there are some merge conflicts.

@geckod22
Copy link
Contributor Author

geckod22 commented Jan 7, 2025

@arunshenoy99 done

arunshenoy99
arunshenoy99 reviewed Jan 7, 2025
View reviewed changes
@arunshenoy99 arunshenoy99 changed the base branch from main to release/v2.3.0 January 8, 2025 07:37
arunshenoy99
arunshenoy99 reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing lint will be handled as part of the code refactor PR: #33

@arunshenoy99 arunshenoy99 merged commit fa6c0b8 into release/v2.3.0 Jan 8, 2025
1 check failed
@arunshenoy99 arunshenoy99 deleted the enhance/PRESS7-70-exclude-from-cache branch January 8, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geckod22 @arunshenoy99