Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Skip 404 by Default #74

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

arunshenoy99
Copy link
Member

Proposed changes

This PR enables the "Skip 404" option by default in the Brand Plugin performance settings. It also fixes a bug where the option was enabled by default in the backend, but the UI incorrectly displayed it as disabled.

image

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 changed the base branch from main to release/v2.4.1 January 22, 2025 14:16
@arunshenoy99 arunshenoy99 merged commit c196798 into release/v2.4.1 Jan 22, 2025
7 of 9 checks passed
@arunshenoy99 arunshenoy99 deleted the enhance/enable-skip404-by-default branch January 22, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants