Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing styles on the Brand Plugin dashboard #93

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

arunshenoy99
Copy link
Member

Proposed changes

This fixes an issue introduced by #64 that was preventing the Brand Plugin dashboard styles from loading for the Web, Crazy Domains, and Mojo plugins. Test failure caught this. I've updated the code to check for the active brand plugin page from the container instead of a hardcoded list of brand names.

image

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 merged commit 8048b63 into release/v2.5.0 Jan 29, 2025
0 of 2 checks passed
@arunshenoy99 arunshenoy99 deleted the release/v2.5.0-bugfix branch January 29, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants