Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate install mdx #19050

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Translate install mdx #19050

merged 4 commits into from
Nov 4, 2024

Conversation

LizBaker
Copy link
Contributor

@LizBaker LizBaker commented Oct 23, 2024

to test you'll need to edit the start script in the package.json and replace BUILD_LANG=en with BUILD_LANG=jp. then create a few folders resulting in these paths: i18n/install/config/jp and i18n/install/jp. copy the config yaml for java and plop it into i18n/install/config/jp. then copy an mdx file from the java mdx and put it in the i18n/install/jp folder. edit that file to look different in some way. finally in the i18n config yaml edit the step path that relates to that mdx file to match the i18n path, e.g. src/i18n/install/jp/java/createDirectory.mdx. run locally as normal and the install page should have picked up on the alternative mdx for the chosen step

  • alternative mdx shows up when the BUILD_LANG is set to jp
  • serializing and deserializing an install mdx page with a works appropriately

@LizBaker LizBaker requested a review from a team as a code owner October 23, 2024 18:23
Copy link

Hi @LizBaker 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@LizBaker LizBaker merged commit e95e631 into feat/french Nov 4, 2024
9 checks passed
@LizBaker LizBaker deleted the liz/translate-install-mdx branch November 4, 2024 17:48
gmanandhar-nr added a commit that referenced this pull request Feb 6, 2025
…-mdx"

This reverts commit e95e631, reversing
changes made to ef67e18.
akashreddy-nr added a commit that referenced this pull request Feb 6, 2025
Revert "Merge pull request #19050 from newrelic/liz/translate-install…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants