Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty Http2 instrumentation can throw an NPE #1947

Closed
jbedell-newrelic opened this issue Jun 13, 2024 · 2 comments · Fixed by #1994
Closed

Netty Http2 instrumentation can throw an NPE #1947

jbedell-newrelic opened this issue Jun 13, 2024 · 2 comments · Fixed by #1994
Assignees
Labels
bug Something isn't working as designed/intended GTSE There is an associated support escalation with this issue. jul-sep qtr Represents proposed work item for the Jul-Sep quarter

Comments

@jbedell-newrelic
Copy link
Contributor

Related GTSE: https://new-relic.atlassian.net/jira/software/c/projects/NR/boards/289?selectedIssue=NR-280663

The following line in Http2RequestWrapper can throw an NPE (and thus reporting an invalid error up) when the method is null:
httpRequest = HttpConversionUtil.toHttpRequest(msg.stream().id(), msg.headers(), true)

Error message is: method header cannot be null in conversion to HTTP/1.x

We need to understand when/why the method can be null and what to do in that case.

@jbedell-newrelic jbedell-newrelic added bug Something isn't working as designed/intended GTSE There is an associated support escalation with this issue. labels Jun 13, 2024
@workato-integration
Copy link

@kford-newrelic kford-newrelic moved this from Triage to In Quarter in Java Engineering Board Jul 9, 2024
@kford-newrelic kford-newrelic added the jul-sep qtr Represents proposed work item for the Jul-Sep quarter label Jul 9, 2024
@jasonjkeller jasonjkeller moved this from In Quarter to In Sprint in Java Engineering Board Jul 29, 2024
@github-project-automation github-project-automation bot moved this from In Sprint to Code Complete/Done in Java Engineering Board Jul 30, 2024
@jasonjkeller
Copy link
Contributor

The Netty classes weaved to support HTTP/2 have been refactored which resulted in the removal of the weave class that was causing the NPE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as designed/intended GTSE There is an associated support escalation with this issue. jul-sep qtr Represents proposed work item for the Jul-Sep quarter
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants