Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor netty instrumentation to support HTTP/2 #1994

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

jasonjkeller
Copy link
Contributor

Resolves #1945
Resolves #1947

@jasonjkeller jasonjkeller self-assigned this Jul 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.60%. Comparing base (764ae62) to head (aec33f1).
Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1994      +/-   ##
============================================
- Coverage     70.88%   70.60%   -0.29%     
+ Complexity    10345     9872     -473     
============================================
  Files           836      829       -7     
  Lines         41484    39914    -1570     
  Branches       6338     6077     -261     
============================================
- Hits          29407    28180    -1227     
+ Misses         9289     9007     -282     
+ Partials       2788     2727      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonjkeller jasonjkeller merged commit 5f497d8 into main Jul 30, 2024
111 checks passed
@jasonjkeller jasonjkeller deleted the netty-http2 branch July 30, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Netty Http2 instrumentation can throw an NPE Investigate HTTP/2 support with Netty/Vert.x
3 participants