fix slick instrumentation on scala 2.13 #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kford-newrelic
added
the
on-roadmap
tbradellis
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Describe the changes present in the pull request
Since agent version 7.9, Slick (and possibly other) modules stopped working using scala 2.13.
While I found what causes the issue as outlined in the linked issue, I have no time to come up with a fix other than avoiding the problematic code path by marking the runnable a
varsuch that theFinalTraitTransformerdoesn't pick upNewRelicRunnableand therefor skips that transformation. Tested this locally and it seems to fix the problem , allowing us to use the agent while a real fix can be developed.Related Github Issue
Issue
Testing
Apart from the existing (and ignored?) tests, I did run the agent built from this branch and verified that the slick instrumentation works.
Checks
[ x] Are your contributions backwards compatible with relevant frameworks and APIs?
[ ] Does your code contain any breaking changes? Please describe.
[ ] Does your code introduce any new dependencies? Please describe.