Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a switch to allow the OTel SDK integration to be completely disabled #1821

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

sdaubin
Copy link
Contributor

@sdaubin sdaubin commented Mar 26, 2024

Overview

This allows the agent's Opentelemetry SDK autoconfiguration feature to be disabled with this setting:

opentelemetry.sdk.autoconfigure.enabled=false

For instance, start a process with this added: -Dnewrelic.config.opentelemetry.sdk.autoconfigure.enabled=false

This feature can currently be disabled by disabling the instrumentation, but this is a nicer looking switch.

Testing

The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,

Checks

  • Your contributions are backwards compatible with relevant frameworks and APIs.
  • Your code does not contain any breaking changes. Otherwise please describe.
  • Your code does not introduce any new dependencies. Otherwise please describe.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.87%. Comparing base (dd32a0f) to head (2a1a397).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1821      +/-   ##
============================================
- Coverage     70.88%   70.87%   -0.01%     
+ Complexity     9974     9971       -3     
============================================
  Files           829      829              
  Lines         39984    39984              
  Branches       6058     6058              
============================================
- Hits          28342    28338       -4     
- Misses         8915     8919       +4     
  Partials       2727     2727              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy jtduffy merged commit 4060a06 into main Apr 1, 2024
107 checks passed
@jtduffy jtduffy deleted the saxon/otel-sdk-kill-switch branch April 1, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants