-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local decorating for customers using Log4j 2 with JsonTemplateLayout #1866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor tweaks to be made but otherwise looks good.
agent-bridge/src/main/java/com/newrelic/agent/bridge/logging/Log4jUtils.java
Show resolved
Hide resolved
instrumentation/apache-log4j-layout-template-json-2.14.0/Readme.md
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
============================================
- Coverage 70.88% 70.69% -0.19%
+ Complexity 9974 9872 -102
============================================
Files 829 828 -1
Lines 39985 39832 -153
Branches 6058 6064 +6
============================================
- Hits 28344 28161 -183
- Misses 8915 8947 +32
+ Partials 2726 2724 -2 ☔ View full report in Codecov by Sentry. |
Overview
Adds local decorating (i.e. NR-LINKING metadata) to log4j 2 logs using
JsonTemplateLayout
such as shown configured in the XML snippet below:Example log without local decorating:
Example log with local decorating:
Related Github Issue
#1730