Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using env variable for config file location #2022

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Aug 22, 2024

Resolves #2020

Now supports the use of the environment variable NEWRELIC_FILE to specify the location of the agent configuration file.

@jtduffy jtduffy requested a review from a team August 22, 2024 17:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (ecc4ae5) to head (ff5a570).
Report is 1 commits behind head on main.

Files Patch % Lines
...va/com/newrelic/agent/config/ConfigFileHelper.java 71.42% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2022   +/-   ##
=========================================
  Coverage     70.58%   70.58%           
- Complexity     9869     9875    +6     
=========================================
  Files           829      829           
  Lines         39915    39945   +30     
  Branches       6077     6078    +1     
=========================================
+ Hits          28173    28195   +22     
- Misses         9010     9020   +10     
+ Partials       2732     2730    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy jtduffy merged commit 3be0439 into main Aug 23, 2024
111 checks passed
@jtduffy jtduffy deleted the config-file-env-var branch August 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow the environment variable NEWRELIC_FILE to specify the location of the agent config file
3 participants