Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2874): sync up pagination docs wiki <-> site #763

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

JohnTParsons
Copy link
Collaborator

PPDSC-2874

What

Minor docs changes to wiki and docs site to bring them into sync content-wise and eliminate typos and inconsistencies.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 24, 2023
@pp-serviceaccount
Copy link
Collaborator

@JohnTParsons JohnTParsons merged commit 18bfe19 into main Mar 24, 2023
@JohnTParsons JohnTParsons deleted the docs/PPDSC-2874-pagination-sync branch March 24, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants