Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActionCheckbox): Fix padding in RTL mode #6354

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(NcActionCheckbox): Fix padding in RTL mode #6354

merged 1 commit into from
Jan 9, 2025

Conversation

falghamdi125
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

Best

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.52%. Comparing base (0d3715f) to head (cc8130c).
Report is 68 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6354      +/-   ##
==========================================
+ Coverage   42.26%   42.52%   +0.25%     
==========================================
  Files         155      156       +1     
  Lines        3996     4026      +30     
  Branches     1001     1036      +35     
==========================================
+ Hits         1689     1712      +23     
+ Misses       2199     2198       -1     
- Partials      108      116       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ShGKme
ShGKme approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ShGKme ShGKme requested a review from hamza221 January 8, 2025 09:49
@ShGKme ShGKme assigned ShGKme and unassigned ShGKme Jan 8, 2025
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components RTL Right-to-Left languages support labels Jan 8, 2025
@ShGKme ShGKme added this to the 8.21.1 milestone Jan 8, 2025
@ShGKme ShGKme requested a review from skjnldsv January 8, 2025 09:50
hamza221
hamza221 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

شكرًا

@ShGKme ShGKme merged commit 17e716f into nextcloud-libraries:master Jan 9, 2025
17 checks passed
@ShGKme
Copy link
Contributor

ShGKme commented Jan 9, 2025

/backport to next

@backportbot backportbot bot mentioned this pull request Jan 9, 2025
Merged
@susnux susnux modified the milestones: 8.21.1, 8.23.0 Jan 15, 2025
@Antreesy Antreesy mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@hamza221 hamza221 hamza221 approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components RTL Right-to-Left languages support
Projects
None yet
Milestone
8.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@falghamdi125 @ShGKme @hamza221 @susnux