Tighter integration - Open in Notes Button

[ZetaTom]

This change introduces a new Open in Notes button to folders managed by the Nextcloud Notes app. Taping on this button will open the Notes app carrying the current account over.

Screenshots

Normal Folder	Notes Folder	Notes Folder (Rich Workspace)

Notes Folder	Notes Folder (Rich Workspace)

Related

• Extend OCCapability to include notes folder location android-library#1665
• add notes path to capabilities notes#1468
• Tighter integration on apps within Nextcloud ecosystem notes-android#1873

---

• Tests written, or not not needed

[ZetaTom]

@jancborchardt, please review the design and placement of the new Open in Notes button. It's designed to look like the Open in Collectives button in the web interface.

[jancborchardt]

Nice! It could be improved a bit by clearly grouping it within an outlined card to separate it from the regular content.
https://m3.material.io/components/cards/overview

[ZetaTom]

@Hyeyoung346, as @jancborchardt suggested, I've placed the Open in Notes button and associated text in a MaterialCardView using the outlined style and default colour theme. In my opinion, the filled style with a grey background is a better choice for this use case. Please review the following screenshots:

Outlined Style	Filled Style

And the Open in Collectives button from the web UI, for reference:

[Hyeyoung346]

@ZetaTom I also think the filled style looks better. But I think this component is more similar to the banner component. I think M3 doesn't have a banner implementation and therefore needs a bit of customization. The M3 guideline recommends a button with low emphasis text for banners, and I think the current button looks a bit large. So I suggest using a text button like this.

What about adding Dismissor Remind me later text button to let users close this banner in case if they don’t want to open in Notes app?

[ZetaTom]

Thank you @Hyeyoung346 for your feedback. This has been discussed with @tobiasKaminsky. We decided to go with the filled card style because implementing the banner style would unfortunately require a lot of work on the surrounding components. Similarly adding a dismiss button would require more logic and is currently considered out of scope for this pull request. We also considered the outlined button in order to reduce the visual strain. Please see the screenshots below:

Outlined Button	Text Button

[Hyeyoung346]

@ZetaTom Yes, it's strange that there are no banner components in M3. I think the text button looks better and this complies with M3 guidelines. As for adding a dismiss text button, I think it would be better to add that option, but can consider to implement later.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14497.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	54	54
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	58
Dodgy code	293	294
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	51	51
Security	18	18
Total	501	502

SpotBugs increased!