Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified share layout #14559

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Simplified share layout #14559

merged 1 commit into from
Feb 25, 2025

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Feb 18, 2025

Closes #14183

  • Tests written, or not not needed

Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotbugs needs to be fixed and I made some suggestions.

@alperozturk96
Copy link
Collaborator

alperozturk96 commented Feb 21, 2025

Please fix, Codacy static code analysis and spotbugs. And screenshots must be updated.

Screenshot 2025-02-21 at 09 53 03

@tobiasKaminsky tobiasKaminsky force-pushed the simplifiedShareLayout branch 3 times, most recently from e97a5b9 to 5d95ca8 Compare February 24, 2025 10:52
@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.31

Signed-off-by: tobiasKaminsky <[email protected]>
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14559.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total502502

@tobiasKaminsky tobiasKaminsky merged commit f3b55a3 into master Feb 25, 2025
19 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the simplifiedShareLayout branch February 25, 2025 07:06
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.32.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Simplified share flow
3 participants